Embed the HAProxy template file in the agent binary

[ema-pe]

Currently in the agent configuration dfaasagent.env there are two keys that are always fixed with the same value in every file I found:

dfaas/dfaasagent.env

Lines 20 to 21 in 3a9fc2b

	AGENT_HAPROXY_TEMPLATE_FILE_NMS="/agent/haproxycfgnms.tmpl"
	AGENT_HAPROXY_TEMPLATE_FILE_RECALC="/agent/haproxycfgrecalc.tmpl"

These two file paths are the same in every configuration file, which means that the agent expects the same file and they are mandatory. To simplify the configuration file and reduce the number of unnecessary keys, we could embed these files into the binary using the Go embed package.

[miciav]

I agree.

[ema-pe]

I do not know if also loadbalancer/group_list.json file can also be included in the binary, but it seems to be a good candidate along with the other two files.

[aletundo]

I actually commented about the group_list.json, I don't think it should be harcoded because it indicates the function group's, but functions can change overtime.

[aletundo]

Currently in the agent configuration dfaasagent.env there are two keys that are always fixed with the same value in every file I found:

dfaas/dfaasagent.env

Lines 20 to 21 in 3a9fc2b

	AGENT_HAPROXY_TEMPLATE_FILE_NMS="/agent/haproxycfgnms.tmpl"
	AGENT_HAPROXY_TEMPLATE_FILE_RECALC="/agent/haproxycfgrecalc.tmpl"

These two file paths are the same in every configuration file, which means that the agent expects the same file and they are mandatory. To simplify the configuration file and reduce the number of unnecessary keys, we could embed these files into the binary using the Go embed package.

If these templates do not need to be modified at deployment time for any reason, yes it makes sense to embed.

[ema-pe]

Currently in the agent configuration dfaasagent.env there are two keys that are always fixed with the same value in every file I found:

dfaas/dfaasagent.env

Lines 20 to 21 in 3a9fc2b

	AGENT_HAPROXY_TEMPLATE_FILE_NMS="/agent/haproxycfgnms.tmpl"
	AGENT_HAPROXY_TEMPLATE_FILE_RECALC="/agent/haproxycfgrecalc.tmpl"

These two file paths are the same in every configuration file, which means that the agent expects the same file and they are mandatory. To simplify the configuration file and reduce the number of unnecessary keys, we could embed these files into the binary using the Go embed package.

If these templates do not need to be modified at deployment time for any reason, yes it makes sense to embed.

Yes, that is the point. I'm thinking if there is a need to change the template after deployment. In any case, the default templates should be embedded to provide some defaults.