Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include forge coverage report #334

Closed
naps62 opened this issue Jul 4, 2023 · 1 comment · Fixed by #393
Closed

Include forge coverage report #334

naps62 opened this issue Jul 4, 2023 · 1 comment · Fixed by #393
Assignees
Labels
A-ci Area: Our CI C-dx Category: Developer Experience C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@naps62
Copy link
Contributor

naps62 commented Jul 4, 2023

It would be useful to get coverage metrics of the EVM test suite

However, that is currently blocked due to compiler issues: coverage checks currently run without optimizations, and without --via-ir, which results in larger / complex contracts failing with "Stack too deep" errors

Some quick research seems to indicate this will be solved in solidity 0.8.21 (next version, no due date yet), so perhaps once that's out we can run coverage by compiling the contracts specifically with that version (or by updating to that compiler if it makes sense)

Relevant issues:

@naps62
Copy link
Contributor Author

naps62 commented Jul 19, 2023

Update, this is now doable by updating foundry, and running forge coverage --ir-minimum (foundry-rs/foundry#5349)

here's a sample run, on my testing branch
image

@hussein-aitlahcen hussein-aitlahcen self-assigned this Jul 27, 2023
@hussein-aitlahcen hussein-aitlahcen added C-dx Category: Developer Experience C-enhancement Category: An issue proposing an enhancement or a PR with one. A-ci Area: Our CI labels Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: Our CI C-dx Category: Developer Experience C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants