Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fuzzing to models #409

Open
benluelo opened this issue Jul 31, 2023 · 1 comment
Open

Add fuzzing to models #409

benluelo opened this issue Jul 31, 2023 · 1 comment
Assignees
@benluelo
Labels
A-unionlabs Area: lib/unionlabs C-enhancement Category: An issue proposing an enhancement or a PR with one. P-low Low priority

Comments

@benluelo
Copy link
Contributor

As #391 pointed out, the tests for our models are currently quite poor. We should add fuzzing to the crate to ensure everything can round-trip encode/decode through json and protobuf.
@benluelo benluelo self-assigned this Jul 31, 2023
@benluelo benluelo added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jul 31, 2023
@benluelo benluelo mentioned this issue Aug 25, 2023
Merged
2 tasks
benluelo added a commit that referenced this issue Aug 25, 2023
@benluelo
feat: update Duration and Timestamp to match proto specs (#517)
407e329 
Updates the `Duration` and `Timestamp` types in unionlabs to be in line
with their proto specs.

TODO:

- [x] More tests for all conversions
- Added basic fuzzing (start of #409). We can look into using
[kani](https://github.com/model-checking/kani) as well.
- [x] Improve docs (these two types likely could use a module doc
explaining why they are the way they are)
- Copied some of the docs from the proto types; this can be expanded
upon in the future.

Also fixed a few clippy warnings because they were annoying me
@benluelo benluelo mentioned this issue Jan 6, 2024
Closed
26 tasks
@benluelo
Copy link
Contributor Author

benluelo commented Mar 7, 2024

partially implemented in #1223, we need to add more continuous fuzzing for this to be worthwhile though.

@benluelo benluelo added P-low Low priority A-unionlabs Area: lib/unionlabs labels Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benluelo benluelo

Labels
A-unionlabs Area: lib/unionlabs C-enhancement Category: An issue proposing an enhancement or a PR with one. P-low Low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benluelo