Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert removal of no_handle from State.run() #48

Open
pederhan opened this issue Feb 15, 2023 · 0 comments
Open

Revert removal of no_handle from State.run() #48

pederhan opened this issue Feb 15, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@pederhan
Copy link
Member

pederhan commented Feb 15, 2023

Commit 7394722 needs to be reverted.

Yeah, didn't think this one through at all; by not having any handling of StatusError exceptions inside State.run() itself, we just instantly exit the REPL with no recourse to recover it. We should instead catch StatusError inside State.run() and then raise a SystemExit in its place if it's unhandled.

This will let certain commands catch StatusError if they want to, but by default they are turned into SystemExit calls through the error handler we already have.

@pederhan pederhan added this to Harbor Feb 15, 2023
@pederhan pederhan added the bug Something isn't working label Feb 15, 2023
@pederhan pederhan changed the title Revert removal of no_handle from State.run Revert removal of no_handle from State.run() Feb 15, 2023
@pederhan pederhan moved this to Todo in Harbor Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant