Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up IP addresses and possibly hostnames used in the tests #296

Open
dmykarp opened this issue Apr 10, 2019 · 0 comments
Open

Clean up IP addresses and possibly hostnames used in the tests #296

dmykarp opened this issue Apr 10, 2019 · 0 comments
Labels
good first issue Good for newcomers

Comments

@dmykarp
Copy link

dmykarp commented Apr 10, 2019

mreg/tests.py and mreg/api/v1/tests.py contain lots of IP addresses and hostnames for the tests. Right now they lack consistency; it would be clearer if we only had addresses from the same private network in all the tests, both for IPv4 and IPv6.

The hostnames in the tests are now supposed to be in .example.org domain, but a check is needed to be sure we don't have a stray test hostname in another domain, also for the reason of consistency and clarity.

@oyvindkolbu oyvindkolbu added the good first issue Good for newcomers label Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants