Compute default error duration if omitted #91
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a computed default for a source collector's
error_duration
based on itsupdate_interval
anderror_tolerance
.Given a the following config, we can expect ZAC to compute a default value for
error_duration
that is between 300 and 359 seconds:This PR uses the following formula to compute the default value:
round(error_tolerance * update_interval + (update_interval*0.9))
. So for the config above, we will get a defaulterror_duration
of 354.The extra duration (
update_interval*0.9
) allows for some accumulated latency during and between updates, while still ensuring 5 successive errors are required to trigger deactivation.