From 826585a5a1b119c2eb7e67fe91a930e721f22516 Mon Sep 17 00:00:00 2001 From: Arya Irani Date: Fri, 5 Jan 2024 19:11:58 -1000 Subject: [PATCH 1/4] remove irrelevant `changed-files` step --- .github/workflows/update-transcripts.yaml | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/.github/workflows/update-transcripts.yaml b/.github/workflows/update-transcripts.yaml index 965eabbb3f..d3ee628b5d 100644 --- a/.github/workflows/update-transcripts.yaml +++ b/.github/workflows/update-transcripts.yaml @@ -77,13 +77,6 @@ jobs: git config --global user.email "actions@github.com" - name: build run: stack --no-terminal build --fast --no-run-tests --test - - name: Get changed files - id: changed-files - uses: tj-actions/changed-files@v41 - with: - files: | - **/*.md - separator: "\n" - name: round-trip-tests run: | mkdir -p /private/tmp @@ -104,7 +97,7 @@ jobs: git add --all # Fail if any transcripts cause git diffs. git diff --cached --ignore-cr-at-eol --exit-code - - name: save transcript changes + - name: save changes uses: stefanzweifel/git-auto-commit-action@v4 with: commit_message: rerun transcripts and round-trip tests From 73aafe303a4d8998eebb7524b0fa14476be1d109 Mon Sep 17 00:00:00 2001 From: Arya Irani Date: Fri, 5 Jan 2024 19:27:30 -1000 Subject: [PATCH 2/4] change the name of the workflow to be less accurate --- .github/workflows/update-transcripts.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/update-transcripts.yaml b/.github/workflows/update-transcripts.yaml index d3ee628b5d..0b888df22a 100644 --- a/.github/workflows/update-transcripts.yaml +++ b/.github/workflows/update-transcripts.yaml @@ -1,4 +1,4 @@ -name: update-golden-tests +name: update-transcripts on: workflow_dispatch: From 1df98bfb73c72a6e816211506e405b77a9b9bae7 Mon Sep 17 00:00:00 2001 From: Arya Irani Date: Fri, 5 Jan 2024 22:17:34 -1000 Subject: [PATCH 3/4] don't fail when there are changes --- .github/workflows/update-transcripts.yaml | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/.github/workflows/update-transcripts.yaml b/.github/workflows/update-transcripts.yaml index 0b888df22a..081b971dbc 100644 --- a/.github/workflows/update-transcripts.yaml +++ b/.github/workflows/update-transcripts.yaml @@ -83,21 +83,10 @@ jobs: touch /private/tmp/roundtrip.u touch /private/tmp/rewrite-tmp.u stack --no-terminal exec unison transcript unison-src/transcripts-round-trip/main.md - git add unison-src/transcripts-round-trip/main.output.md - # Fail if any transcripts cause git diffs. - git diff --cached --ignore-cr-at-eol --exit-code stack --no-terminal exec unison transcript unison-src/transcripts-manual/rewrites.md - git add unison-src/transcripts-manual/rewrites.output.md - # Fail if any transcripts cause git diffs. - git diff --cached --ignore-cr-at-eol --exit-code - name: transcripts - run: | - stack --no-terminal exec transcripts - # Add all changes to the index for when we diff. - git add --all - # Fail if any transcripts cause git diffs. - git diff --cached --ignore-cr-at-eol --exit-code - - name: save changes + run: stack --no-terminal exec transcripts + - name: save transcript changes uses: stefanzweifel/git-auto-commit-action@v4 with: commit_message: rerun transcripts and round-trip tests From 511f323bb7133731204bfceabfaf2b58984d018f Mon Sep 17 00:00:00 2001 From: Arya Irani Date: Sat, 6 Jan 2024 07:20:38 -1000 Subject: [PATCH 4/4] can we run ci.yaml manually? --- .github/workflows/ci.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 130d0312e0..d284c4889e 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -15,6 +15,8 @@ on: - trunk tags: - release/* + workflow_dispatch: + jobs: