Fixes for python-us #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Seekins <[email protected]>
|
Thank you @dgilmanAIDENTIFIED we've switched to your PiPy package for the time being 👍 |
|
Hey @dgilmanAIDENTIFIED would you be open to being a maintainer of this package along with @pauldhawk? |
|
I'm OK with that. I slid into your DMs on Twitter to offer the same thing. If you can get us all in touch let's talk. |
|
@dgilmanAIDENTIFIED do you plan on finishing this PR or should we close it? |
|
@dgilmanAIDENTIFIED could you send me your email at [email protected] so I can start a thread? @pauldhawk I already have yours |
|
Email sent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the fixes I've merged/made to python-us to get it up and working again. I have uploaded this to PyPI as package
us-aidentifiedversion 3.0.1. Feel free to merge this or give any feedback on what you'd like to see for an official release.#66: I merged this in
#64: close, this obsoletes it
#60: close, this fixes it
#65 close, this fixes it
#63 close, this obsoletes it
#58 close, this fixes it
#57 close, fixed in latest jellyfish
#56 close, this fixes it
#55 close, this fixes it
#54 I wrote a fix to this - turns out the cache wasn't running at all!
#52 I wrote a fix to this. Added a kwarg
additional_metaphonesto lookup() that takes a dict mapping metaphones to metaphones. I added a default dictionary with the Washington DC case, typos we've seen, and the Commonwealths. I think it's an OK fix but your input is welcome.#33 I think the shapefile URLs take care of this?
#32 the DC_STATEHOOD envvar takes care of this, close
#14 and #15: close, this fixes it. I wrote a test that uses census shapefiles + the IANA timezone database to validate we have up-to-date timezones in each state.