feat: improved test coverage

Author: corp-0

src/accounts/api/serializers.py

@@ -93,7 +93,7 @@ def validate(self, data):
 
         if not account_confirmation.is_token_valid():
             raise serializers.ValidationError({"token": "Token is invalid or expired."})
-        return {"token": data["token"]}
+        return {"token": data["token"], "account_confirmation": account_confirmation}
 
 
 class EmailSerializer(serializers.Serializer):

src/accounts/api/views.py

@@ -324,7 +324,7 @@ def post(self, request):
         if not serializer.is_valid():
             return ErrorResponse(serializer.errors, status.HTTP_400_BAD_REQUEST)
 
-        account_confirmation = AccountConfirmation.objects.get(token=serializer.validated_data["token"])
+        account_confirmation: AccountConfirmation = serializer.validated_data["account_confirmation"]
         account = account_confirmation.account
 
         account.is_confirmed = True

src/central_command/settings.py

@@ -165,6 +165,18 @@
     }
 }
 
+
+if "test" in sys.argv:
+    DATABASES["default"] = {
+        "ENGINE": "django.db.backends.sqlite3",
+        "NAME": ":memory:",
+    }
+
+    CACHES["default"] = {
+        "BACKEND": "django.core.cache.backends.locmem.LocMemCache",
+        "LOCATION": "tests",
+    }
+
 REST_FRAMEWORK = {
     "DEFAULT_SCHEMA_CLASS": "drf_spectacular.openapi.AutoSchema",
     "DEFAULT_AUTHENTICATION_CLASSES": ["knox.auth.TokenAuthentication"],

src/tests/accounts/endpoints/test_confirm_account.py

@@ -0,0 +1,38 @@
+from django.core.cache import cache
+from django.urls import reverse
+from rest_framework import status
+from rest_framework.test import APITestCase
+
+from accounts.models import Account, AccountConfirmation
+
+
+class ConfirmAccountTest(APITestCase):
+    def setUp(self) -> None:
+        cache.clear()
+        self.account = Account.objects.create_user(
+            username="confirmUser",
+            email="[email protected]",
+            unique_identifier="confirmUser",
+        )
+        self.account.set_password("aValidPss963")
+        self.account.is_confirmed = False
+        self.account.save()
+
+        self.confirmation = AccountConfirmation.objects.create(account=self.account, token="confirm-token")  # noqa: S106 - test-only credential
+        self.url = reverse("account:confirm")
+
+    def test_confirm_account_with_valid_token(self) -> None:
+        response = self.client.post(self.url, {"token": self.confirmation.token}, format="json")
+
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+
+        self.account.refresh_from_db()
+        self.assertTrue(self.account.is_confirmed)
+        self.assertFalse(AccountConfirmation.objects.filter(pk=self.confirmation.pk).exists())
+
+    def test_confirm_account_with_invalid_token(self) -> None:
+        response = self.client.post(self.url, {"token": "invalid-token"}, format="json")
+
+        self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
+        self.account.refresh_from_db()
+        self.assertFalse(self.account.is_confirmed)

src/tests/accounts/endpoints/test_login_credentials.py

@@ -1,3 +1,4 @@
+from django.core.cache import cache
 from django.urls import reverse
 from rest_framework import status
 from rest_framework.test import APITestCase
@@ -7,6 +8,7 @@
 
 class LoginCredentialsTest(APITestCase):
     def setUp(self):
+        cache.clear()
         self.url = reverse("account:login-credentials")
         self.valid_account = Account.objects.create_user(
             username="validUser",

src/tests/accounts/endpoints/test_login_token.py

@@ -1,3 +1,4 @@
+from django.core.cache import cache
 from django.urls import reverse
 from rest_framework import status
 from rest_framework.test import APITestCase
@@ -7,6 +8,7 @@
 
 class LoginTokenTest(APITestCase):
     def setUp(self):
+        cache.clear()
         self.url = reverse("account:login-token")
         self.valid_account = Account.objects.create_user(
             username="validUser",

src/tests/accounts/endpoints/test_register.py

@@ -1,3 +1,6 @@
+from unittest.mock import patch
+
+from django.core.cache import cache
 from django.urls import reverse
 from rest_framework import status
 from rest_framework.test import APITestCase
@@ -7,6 +10,7 @@
 
 class RegisterTest(APITestCase):
     def setUp(self):
+        cache.clear()
         self.url = reverse("account:register")
         self.valid_data = {
             "email": "[email protected]",
@@ -101,3 +105,15 @@ def test_confirmed_state_at_registering(self):
         self.assertEqual(response.status_code, status.HTTP_200_OK)
         created_account = Account.objects.get(email=self.valid_data["email"])
         self.assertFalse(created_account.is_confirmed)
+
+    def test_register_sends_confirmation_email(self):
+        data = self.valid_data.copy()
+        data["email"] = "[email protected]"
+        data["unique_identifier"] = "newuser"
+        data["username"] = "newuser"
+
+        with patch("accounts.models.Account.send_confirmation_mail") as mock_send:
+            response = self.client.post(self.url, data, format="json")
+
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+        mock_send.assert_called_once()

src/tests/accounts/endpoints/test_reset_password.py

@@ -1,3 +1,6 @@
+from unittest.mock import patch
+
+from django.core.cache import cache
 from django.urls import reverse
 from rest_framework import status
 from rest_framework.test import APITestCase
@@ -11,6 +14,7 @@ def get_reset_url(token):
 
 class PasswordResetTest(APITestCase):
     def setUp(self):
+        cache.clear()
         self.valid_account = Account.objects.create_user(
             username="validUser",
             email="[email protected]",
@@ -37,6 +41,16 @@ def test_request_password_reset_with_valid_email(self):
         password_reset_request = PasswordResetRequestModel.objects.first()
         self.assertIsNotNone(password_reset_request)
 
+    def test_request_password_reset_sends_email(self):
+        data = {"email": "[email protected]"}
+
+        with patch("accounts.api.views.send_email_with_template") as mock_send:
+            response = self.client.post(self.url_request, data, format="json")
+
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+        mock_send.assert_called_once()
+        self.assertEqual(mock_send.call_args.kwargs["recipient"], data["email"])
+
     def test_request_password_reset_with_invalid_email(self):
         data = {"email": "[email protected]"}
 

src/tests/accounts/endpoints/test_server_verification_token.py

@@ -1,3 +1,4 @@
+from django.core.cache import cache
 from django.urls import reverse
 from rest_framework import status
 from rest_framework.test import APITestCase
@@ -7,6 +8,7 @@
 
 class ServerVerificationTokenTest(APITestCase):
     def setUp(self):
+        cache.clear()
         self.valid_account = Account.objects.create_user(
             username="validUser",
             email="[email protected]",
@@ -57,6 +59,8 @@ def test_verify_with_invalid_token(self):
     def test_verify_with_invalid_identifier(self):
         self.client.credentials(HTTP_AUTHORIZATION=f"Token {self.token}")
         response = self.client.get(self.url_request, format="json")
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+        self.assertIn("verification_token", response.data)
 
         data = {"verification_token": response.data["verification_token"], "unique_identifier": "invalidIdentifier"}
         response = self.client.post(self.url_verify, data, format="json")

src/tests/baby_serverlist/test_api.py

@@ -1,7 +1,7 @@
-from datetime import UTC, datetime
+from datetime import UTC, datetime, timedelta
+from uuid import uuid4
 
 from django.core.cache import cache
-from django.test import override_settings
 from django.urls import reverse
 from rest_framework import status
 from rest_framework.test import APITestCase
@@ -39,14 +39,6 @@ def _sample_status_payload(server_token: str) -> dict[str, object]:
     }
 
 
-@override_settings(
-    CACHES={
-        "default": {
-            "BACKEND": "django.core.cache.backends.locmem.LocMemCache",
-            "LOCATION": "baby-serverlist-tests",
-        }
-    }
-)
 class BabyServerAPITests(APITestCase):
     def setUp(self) -> None:
         self.user = Account.objects.create_user(
@@ -102,6 +94,17 @@ def test_regenerate_token_rejects_non_owner(self) -> None:
 
         self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)
 
+    def test_regenerate_token_not_found_returns_404(self) -> None:
+        self.client.force_authenticate(self.user)
+
+        response = self.client.post(
+            reverse("baby_serverlist:regenerate-token"),
+            {"server_id": str(uuid4())},
+            format="json",
+        )
+
+        self.assertEqual(response.status_code, status.HTTP_404_NOT_FOUND)
+
     def test_post_server_status_stores_payload_in_cache(self) -> None:
         baby_server = BabyServer.objects.create(owner=self.user, whitelisted=True)
         payload = _sample_status_payload(baby_server.serverlist_token)
@@ -151,6 +154,12 @@ def test_list_owned_baby_servers_live_flag(self) -> None:
         response = self.client.get(reverse("baby_serverlist:list-owned"))
         self.assertTrue(response.json()[0]["live"])
 
+        stale_time = datetime.now(tz=UTC) - timedelta(seconds=13)
+        set_baby_server_heartbeat(str(baby_server.id), stale_time.isoformat())
+
+        response = self.client.get(reverse("baby_serverlist:list-owned"))
+        self.assertFalse(response.json()[0]["live"])
+
     def test_list_baby_servers_returns_whitelisted_status(self) -> None:
         baby_server = BabyServer.objects.create(owner=self.user, whitelisted=True)
         status_data = _sample_status_payload(baby_server.serverlist_token)