Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jsdocs): collapse prop #26

Closed
wants to merge 4 commits into from
Closed

feat(jsdocs): collapse prop #26

wants to merge 4 commits into from

Conversation

cpreston321
Copy link
Member

🔗 Linked issue

#14

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves: #14

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@cpreston321
Copy link
Member Author

Thoughts?

  • How to set which group to default to <details open>?
  • Should we default to first group to default to open?

@uncenter
Copy link
Collaborator

uncenter commented Feb 7, 2024 •
edited
Loading

How to set which group to default to <details open>?

How about expanded="group1 group2" or opened="group1 group2"?

@cpreston321
Copy link
Member Author

@uncenter I guess that would work but you set the group on the code level using a @group utils which makes it a little confusing / strange. I assume that works but github 'closes' by default then open is optional

@pi0
Copy link
Member

pi0 commented Feb 21, 2024

(PR now has too many conflicts. let's wait little bit longer to see how this generator will be used first before implementing and track with #14)

@pi0 pi0 closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

opt-in collapse rendering
3 participants
@cpreston321 @uncenter @pi0