feat: enhance domain validate with regex, support wildcard domain and path validate #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good & certainly a useful addition. If the merge conflicts were addressed & potentially |
jameswragg
reviewed
Nov 23, 2023
| @@ -26,18 +26,31 @@ export const createHTTPSource: SourceFactory<HTTPSourceOptions> = (options) => { | |||
| if (!HTTP_RE.test(d)) { | |||
| d = "http://" + d; | |||
| } | |||
| return new URL(d).hostname; | |||
| const { hostname, pathname } = new URL(d); | |||
| const regExpUrl = `${hostname}${pathname}`.replaceAll("*.", "(\\w*.)?"); | |||
There was a problem hiding this comment.
Allow for multiple subdomains?
Suggested change
| const regExpUrl = `${hostname}${pathname}`.replaceAll("*.", "(\\w*.)?"); | |
| const regExpUrl = `${hostname}${pathname}`.replaceAll("*.", "(\\w*.)+?"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
I modified the original simple hostname check to support both hostname and pathname validation, and I also added the capability to use wildcard domain verification. ( use regex )
📝 Checklist
This feature has not been documented yet.