Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

animated modifier not being respected when used with format_webp #234

Open
jameswragg opened this issue Jul 5, 2024 · 0 comments · May be fixed by #235
Open

animated modifier not being respected when used with format_webp #234

jameswragg opened this issue Jul 5, 2024 · 0 comments · May be fixed by #235
Labels
bug

Comments

@jameswragg
Copy link
Contributor

Environment

Node v20.12.1

Reproduction

/format_auto,animated/ should negotiate only the image formats that support animation (webp/gif)

Describe the bug

The following code tries to limit the format_auto modifier to image formats that support animation but animated is always falsy https://github.com/unjs/ipx/blob/main/src/server.ts#L183-L186

Additional context

No response

Logs

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: animated modifier wasn't correctly being passed to autoDetectFormat jameswragg/ipx
1 participant
@jameswragg