Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: animated modifier wasn't correctly being passed to autoDetectFormat #235

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jameswragg
Copy link
Contributor

Fixes #234

Using animated modifier creates the following modifier key/value which wasn't seen as a truthy value when used in combination with format_auto meaning the format selection wasn't limited to "image/webp", "image/gif":

{
  animated: ''
}

jameswragg and others added 2 commits July 5, 2024 11:53
Using `animated` modifier creates the following modifier key/value which wasn't seen as a truthy value when using `format_auto`:
```
{
  animated: ''
}
```
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.02%. Comparing base (f666cb4) to head (364d77d).
Report is 16 commits behind head on main.

Files Patch % Lines
src/server.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #235   +/-   ##
=======================================
  Coverage   56.02%   56.02%           
=======================================
  Files          14       14           
  Lines        1203     1203           
  Branches       83       84    +1     
=======================================
  Hits          674      674           
  Misses        526      526           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

animated modifier not being respected when used with format_webp
1 participant