Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adjust GenerateUnoSplash targets to have proper inputs for better incrementality #294

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Adjust GenerateUnoSplash targets to have proper inputs for better incrementality #294

wants to merge 1 commit into from
+30 −7

Conversation

Youssef1313
Copy link
Member

Fixes: #293

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@Youssef1313 Youssef1313 mentioned this pull request Jun 10, 2024
Open
@Youssef1313
Copy link
Member Author

@dansiegel Can you please review?

dansiegel
dansiegel reviewed Jun 10, 2024
View reviewed changes
Copy link
Contributor

@dansiegel dansiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I agree with the premise, the timing isn't great for this. Resizetizer has a habit of being fragile and unless we have a specific issue that we can really test for I'd like to avoid making any changes until we're ready to do a larger scale update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dansiegel dansiegel dansiegel left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Potential build incrementality issue
2 participants
@Youssef1313 @dansiegel