Window title not shown when packaged #309
Open
+250
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
Aug 6, 2024
Youssef1313
reviewed
Aug 14, 2024
| var compilationProvider = context.CompilationProvider; | ||
| var additionalTextsProvider = context.AdditionalTextsProvider; | ||
|
|
||
| // Combine optionsProvider and compilationProvider |
There was a problem hiding this comment.
That's no longer incremental once you combine with compilationProvider.
Instead, use an assembly name provider:
var assemblyNameProvider = context.CompilationProvider.Select((compilation, _) => compilation.Assembly.Name);
Youssef1313
reviewed
Aug 14, 2024
| <PrivateAssets>all</PrivateAssets> | ||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> | ||
| </PackageReference> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.10.0" /> |
There was a problem hiding this comment.
This is a too recent. We should really be using the oldest version we can and bump only if there is a specific new API we need
Youssef1313
reviewed
Aug 14, 2024
| <PropertyGroup> | ||
| <TargetFramework>netstandard2.0</TargetFramework> | ||
| <IsPackable>false</IsPackable> | ||
| <AssemblyName>Uno.Resizetizer</AssemblyName> |
There was a problem hiding this comment.
Should the assembly name be Uno.Resizetizer.Generators?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
WinUI Desktop is shown when running the WinUI head packaged.
What is the new behavior?
The Application Title is shown regardless of whether the WinUI head is running Packaged or Unpackaged.