Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove __SKIA_OR_WASM__ in favor of UNO_REFERENCE_API once updating to Uno 5.1+ #1078

Open
kazo0 opened this issue Mar 19, 2024 · 0 comments
Open

Remove __SKIA_OR_WASM__ in favor of UNO_REFERENCE_API once updating to Uno 5.1+ #1078

kazo0 opened this issue Mar 19, 2024 · 0 comments

Comments

@kazo0
Copy link
Contributor

kazo0 commented Mar 19, 2024 •
edited
Loading

Maybe add <DefineConstants Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == ''">$(DefineConstants);__SKIA_OR_WASM__</DefineConstants>

Then use __SKIA_OR_WASM__ instead of UNO_REFERENCE_API. It would also be good to add a comment on that line saying that UNO_REFERENCE_API can be used once the project is upgraded to Uno 5.1

Originally posted by @Youssef1313 in #1071 (comment)
@kazo0 kazo0 changed the title Remove __SKIA_OR_WASM__ in favor of UNO_REFERENCE_API Remove __SKIA_OR_WASM__ in favor of UNO_REFERENCE_API once updating to Uno 5.1+ Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kazo0