fix(TabBar): dp exceptions when using TBI as ItemTemplate root #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Xiaoy312
force-pushed
the
dev/xygu/20241204/tabbar-nested-tbi-containerstyle
branch
from
71a4aba to
42fd720
Compare
|
|
|
fixme@xy: // failing in all ios/droid/wasm
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #1285
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When using TabBar::ItemTemplate with TabBarItem as the root element, there are multiple exceptions throw on item materialization causing performance degradation:
What is the new behavior?
^ no more.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
regression from #1261, which added support for TabBar::ItemTemplate with TabBarItem as the root element.