Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround for regressions caused by ItemsPanelRoot resolution timing #1294

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

Xiaoy312
Copy link
Contributor

@Xiaoy312 Xiaoy312 commented Nov 27, 2024

GitHub Issue (If applicable): closes #1287, closes #1293

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Various dp handler and initialization method for chips and tabbar are affected by the unavailability of ItemsPanelRoot at during Loaded time.

What is the new behavior?

These methods are called again when ItemsPanelRoot becomes available.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Tested the changes where applicable:
    • Skia
  • Updated the documentation as needed:
  • Runtime Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Associated with an issue (GitHub or internal)
  • Commits must be following the Conventional Commits specification.

@Xiaoy312 Xiaoy312 changed the title fix(tabbar): initial orientation and selection not working workaround for regressions caused by ItemsPanelRoot resolution timing Nov 27, 2024
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20241127/items-panel-root-patch branch from b75cbe2 to 8f940b1 Compare November 27, 2024 22:44
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20241127/items-panel-root-patch branch from 8f940b1 to 93436c5 Compare November 27, 2024 22:45
@Xiaoy312 Xiaoy312 marked this pull request as ready for review November 27, 2024 22:45
@Xiaoy312 Xiaoy312 requested a review from kazo0 November 27, 2024 22:45
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1294.eastus2.azurestaticapps.net

1 similar comment
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1294.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20241127/items-panel-root-patch branch from 93436c5 to abc3692 Compare November 28, 2024 01:53
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1294.eastus2.azurestaticapps.net

@kazo0 kazo0 enabled auto-merge (squash) November 28, 2024 02:14
@kazo0 kazo0 merged commit 91c5efc into main Nov 28, 2024
28 checks passed
@kazo0 kazo0 deleted the dev/xygu/20241127/items-panel-root-patch branch November 28, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants