Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lambda updates instead of CreateNewOnMetadataUpdateAttribute #17330

Closed
jeromelaban opened this issue Jun 27, 2024 · 1 comment
Closed

Use lambda updates instead of CreateNewOnMetadataUpdateAttribute #17330

jeromelaban opened this issue Jun 27, 2024 · 1 comment
Assignees
@dr1rrb
Labels
area/hot-reload Categorizes an issue or PR as relevant to hot reload difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request project/core-tools 🛠️ Categorizes an issue or PR as relevant to core and tools

Comments

@jeromelaban
Copy link
Member

jeromelaban commented Jun 27, 2024 •
edited
Loading

What would you like to be added

Update the Uno source generators to avoid using CreateNewOnMetadataUpdateAttribute in order to make iOS work (new types on same native types is not supported).

The only catch for this feature is MetadataUpdateHanders not being supported yet on VS 2022 for iOS/Android (this, this), and updatedTypes not working on wasm (this), which means we still need a way to detect updated types.

Possibly, we could generate internal CreateNewOnMetadataUpdateAttribute tagged empty types that mirror the original modified types, so that we can determine what was actually changed and raise MetadataUpdateHandlers in Partial Reload.
@jeromelaban jeromelaban added kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. project/core-tools 🛠️ Categorizes an issue or PR as relevant to core and tools area/hot-reload Categorizes an issue or PR as relevant to hot reload and removed triage/untriaged Indicates an issue requires triaging or verification labels Jun 27, 2024
@jeromelaban
Copy link
Member Author

Duplicate of #15918

@jeromelaban jeromelaban marked this as a duplicate of #15918 Jun 28, 2024
@jeromelaban jeromelaban closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dr1rrb dr1rrb

Labels
area/hot-reload Categorizes an issue or PR as relevant to hot reload difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request project/core-tools 🛠️ Categorizes an issue or PR as relevant to core and tools
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeromelaban @dr1rrb