Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Controls on previous Page still clickable after navigation #17906

Open
morning4coffe-dev opened this issue Aug 11, 2024 · 7 comments
Open
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform project/navigation-lifecycle 🧬 Categorizes an issue or PR as relevant to the navigation and lifecycle (NavigationView, AppBar, ...) project/pointers 🖱️ Categorizes an issue or PR as relevant to mouse/touch/pen pointers triage/untriaged Indicates an issue requires triaging or verification

Comments

@morning4coffe-dev
Copy link
Member

morning4coffe-dev commented Aug 11, 2024

Current behavior

When a new Recommended app is created and the user navigates to a different page, the controls on the previous page remain clickable or interactive. This can result in unintended actions being triggered on the previous page, even though the user is no longer viewing it:

Screen.Recording.2024-08-11.142753.mp4

Expected behavior

No response

How to reproduce it (as minimally and precisely as possible)

  1. Create a new Recommended app
  2. Navigate in the app
  3. Click on the space where the button is on the previous page

Workaround

No response

Works on UWP/WinUI

Yes

Environment

No response

NuGet package version(s)

"Uno.Sdk": "5.3.96" or "Uno.Sdk": "5.4.0-dev.180"

Affected platforms

Android
iOS? - not able to test

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

@morning4coffe-dev morning4coffe-dev added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Aug 11, 2024
@MartinZikmund MartinZikmund self-assigned this Aug 26, 2024
@MartinZikmund
Copy link
Member

The recommended template has

 Background="{ThemeResource $themeBackgroundBrush$}"

Which in case of Material becomes ThemeResource BackgroundBrush - does this brush exist in Material?

Not sure if relevant, but just seemed interesting

@jeromelaban
Copy link
Member

/cc @kazo0

@kazo0
Copy link
Contributor

kazo0 commented Aug 26, 2024

@MartinZikmund yes BackgroundBrush should be a valid material brush

@MartinZikmund MartinZikmund removed their assignment Aug 28, 2024
@Youssef1313 Youssef1313 self-assigned this Aug 28, 2024
@Youssef1313 Youssef1313 added platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform project/pointers 🖱️ Categorizes an issue or PR as relevant to mouse/touch/pen pointers project/navigation-lifecycle 🧬 Categorizes an issue or PR as relevant to the navigation and lifecycle (NavigationView, AppBar, ...) labels Aug 28, 2024
@Youssef1313 Youssef1313 removed their assignment Aug 28, 2024
@MartinZikmund
Copy link
Member

@jeromelaban According to investigation by @Youssef1313, pre-requisite to fixing this is #17645 - this one feels quite urgent though, as it could mean people will accidentally click and trigger operations on previous pages in navigation stack as things stand.

@Youssef1313
Copy link
Member

To add a bit of into. This seems like a ContentControl/ContentPresenter bug. I have a PR to align ContentControl/ContentPresenter on Skia which is blocked on TemplatedParent. So, after TemplatedParent is merged I could try to get my PR to be for all platforms rather than Skia only

@Xiaoy312 Xiaoy312 removed their assignment Nov 29, 2024
@Xiaoy312
Copy link
Contributor

well tp is completed... so you may proceed with CC/CP

@morning4coffe-dev
Copy link
Member Author

CC @MartinZikmund I think this should be prioritized now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform project/navigation-lifecycle 🧬 Categorizes an issue or PR as relevant to the navigation and lifecycle (NavigationView, AppBar, ...) project/pointers 🖱️ Categorizes an issue or PR as relevant to mouse/touch/pen pointers triage/untriaged Indicates an issue requires triaging or verification
Projects
None yet
Development

No branches or pull requests

6 participants