Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime tests failing due to WaitFor timeout #17984

Open
MartinZikmund opened this issue Aug 21, 2024 · 2 comments
Open

Runtime tests failing due to WaitFor timeout #17984

MartinZikmund opened this issue Aug 21, 2024 · 2 comments
Labels
area/tests 🧪 Categorizes an issue or PR as relevant to tests difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Something isn't working

Comments

@MartinZikmund
Copy link
Member

MartinZikmund commented Aug 21, 2024 •
edited
Loading

Current behavior

Several runtime tests are failing after changes made in #17983 . Enable the tests one by one in separate PRs and cross-out those which are done

  • PrimaryCommandItemsDoNotDisappear
  • When_BackButton_Pressed
  • ValidateAppBarButtonsAreOffsetWithAppBarToggleButtons
  • CanOpenMinimalAppBarUsingMouse (non-Skia targets)
  • CanScrollAcrossJapaneseEraOnMonthView (non-Skia targets)
  • ValidateInlineCommandBarLightDismissBehavior (non-Skia targets)
  • ValidateClosedMinimalCommandBarWithSecondaryCommandsOnlyIsVisible (iOS only)
  • ValidateDefaultLayoutPositionPropagates (Android and iOS)
  • ValidateResetingTheStateOfAppBarButton (non-Skia targets)
  • DoesCloseOnPrimaryCommandSelection (iOS only)
  • DoesCloseOnSecondaryCommandSelection (iOS only)
  • ValidateMenuSizingForDifferentInputModes (Android only)
  • ValidateClosedMinimalCommandBarWithSecondaryCommandsOnlyIsVisible (Android and iOS)
  • CanOpenAndCloseUsingMoreButton (Android and iOS)
  • CanScrollAcrossJapaneseEraOnYearView (iOS and Android)

Expected behavior

No response

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

No response

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response
@MartinZikmund MartinZikmund added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Aug 21, 2024
MartinZikmund added a commit that referenced this issue Aug 21, 2024
@MartinZikmund
chore: Ignore failing tests
98fb932 
Included in #17984
MartinZikmund added a commit that referenced this issue Aug 21, 2024
@MartinZikmund
chore: Ignore failing tests
72e5ae5 
Included in #17984
@MartinZikmund MartinZikmund added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. area/tests 🧪 Categorizes an issue or PR as relevant to tests difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers and removed triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Aug 21, 2024
MartinZikmund added a commit that referenced this issue Aug 22, 2024
@MartinZikmund
chore: Ignore failing tests
57997ac 
Included in #17984
MartinZikmund added a commit that referenced this issue Aug 22, 2024
@MartinZikmund
chore: Ignore failing tests
8a7c4ed 
Included in #17984
MartinZikmund added a commit that referenced this issue Aug 22, 2024
@MartinZikmund
chore: Ignore failing tests
0ddeb87 
Included in #17984
@Murphite
Copy link

Hi Martin, can i contribute to this project?

@MartinZikmund
Copy link
Member Author

@Murphite sure thing! We have a contribution guide here https://github.com/unoplatform/uno/blob/master/CONTRIBUTING.md, you should find all required resources there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/tests 🧪 Categorizes an issue or PR as relevant to tests difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MartinZikmund @Murphite