Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VisualTreeHelper.GetOpenPopupsForXamlRoot must not return Uno.Diagnostics.UI.DiagnosticsOverlay #18961

Open
FrozDark opened this issue Nov 29, 2024 · 1 comment
Labels
area/popups 💬 Categorizes an issue or PR as relevant to popups or flyouts difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers kind/bug Something isn't working

Comments

@FrozDark
Copy link

Current behavior

VisualTreeHelper.GetOpenPopupsForXamlRoot is returning the debugging popup overlay with child of type Uno.Diagnostics.UI.DiagnosticsOverlay
And I have to check it in the Debug

foreach (var popup in VisualTreeHelper.GetOpenPopupsForXamlRoot(XamlRoot))
{
        f (popup.Child.GetType() == typeof(Uno.Diagnostics.UI.DiagnosticsOverlay))
        {
               continue;
        }
        popup.IsOpen = false;
}

Expected behavior

No return

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

No response

Works on UWP/WinUI

None

Environment

Uno.WinUI / Uno.WinUI.WebAssembly / Uno.WinUI.Skia

NuGet package version(s)

"Uno.Sdk": "5.5.43"

Affected platforms

No response

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

@FrozDark FrozDark added difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification labels Nov 29, 2024
@MartinZikmund MartinZikmund added difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers area/popups 💬 Categorizes an issue or PR as relevant to popups or flyouts and removed triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Jan 2, 2025
@MartinZikmund
Copy link
Member

@dr1rrb This could be fixed by adding some checks in VisualTreeHelper for Uno targets, but when on WinUI, it will remain an issue. The only solution I can think of is to turn the overlay into a control, which would just float above the UI, while not actually being a popup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/popups 💬 Categorizes an issue or PR as relevant to popups or flyouts difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants