Feature/stop sound widget #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoMehlig
requested changes
Feb 23, 2025
App/IntentRunner.swift
Outdated
| } | ||
|
|
||
| guard let fileURL = intent.sound.file.fileURL, let newPlayer = try? AudioPlayer(url: fileURL) else { | ||
| print("Failed to create player for \(intent.sound.title)") |
There was a problem hiding this comment.
If we throw an error here, the user will get an error
There was a problem hiding this comment.
Done in 3948880
App/IntentRunner.swift
Outdated
| } catch { | ||
| print("Playing Sound fauled error:", error.localizedDescription) | ||
| print("Playing Sound failed error:", error.localizedDescription) | ||
| activePlayer[intent.sound.id] = nil |
There was a problem hiding this comment.
activePlayer[intent.sound.id] = nil can be moved after the catch block to avoid repeating.
There was a problem hiding this comment.
actually we should probably throw an error if the sounds fails to play. in this case you can use defer to still nil the active player.
There was a problem hiding this comment.
Done in 032f0c0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix based on the suggestion in this ticket:
#7
Now there’s a consistent behavior between the app and the widget. Also updated to use the id instead of the title because if two sounds had the same name, both would get stopped. You can now play multiple sounds and stop them individually!