Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch component toggle with the space key #215

Closed
edtorba opened this issue Jul 19, 2023 · 6 comments
Closed

Switch component toggle with the space key #215

edtorba opened this issue Jul 19, 2023 · 6 comments
Labels
help wanted Extra attention is needed high priority

Comments

@edtorba
Copy link
Contributor

edtorba commented Jul 19, 2023

Describe the bug
Cannot toggle switch component when focused using space key.

To Reproduce
Steps to reproduce the behavior:

  1. Using tab focus on switch component
  2. Press "space"

Expected behavior
Switch should toggle.

@edtorba
Copy link
Contributor Author

edtorba commented Jul 19, 2023

To add... It seems that it has an incorrect role, as it should be switch I believe.

Screenshot 2023-07-19 171146

@k11q
Copy link
Member

k11q commented Jul 19, 2023

Thanks, yeah we realised this, do you want to contribute? I can guide you if you want. This is one of the components we are planning on having major rewrite hence the delay

@k11q
Copy link
Member

k11q commented Jul 19, 2023

closed with #216

@k11q k11q closed this as completed Jul 19, 2023
@edtorba
Copy link
Contributor Author

edtorba commented Jul 19, 2023

@khairulhaaziq I see you guys already closed this issue, nice 👍

Let me know if you guys need an extra hand with getting this project moving. Don't mind helping.

@k11q
Copy link
Member

k11q commented Jul 19, 2023

@khairulhaaziq I see you guys already closed this issue, nice 👍

Let me know if you guys need an extra hand with getting this project moving. Don't mind helping.

we definitely need alot of help. pick any issue if you can 👍, and join our discord

@edtorba
Copy link
Contributor Author

edtorba commented Jul 21, 2023

Joined 👍 am going to familiarise myself with the project, and will drop a msg when ready to pick stuff up 🤜🤛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed high priority
Projects
None yet
Development

No branches or pull requests

2 participants