You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now we have many components for input, example:
<FormFieldv-slot="{ componentField }" name="name">
<FormItem>
<FormLabel>Name</FormLabel>
<FormControl>
<Input
type="text"
placeholder="Your name"
v-bind="componentField"
/>
</FormControl>
<FormDescription>
This is your public display name.
</FormDescription>
<FormMessage />
</FormItem>
</FormField>
We can reduce by passing, optionally, the label and description via props, and also the error is display conditionally instead of description, such avoiding to have description and error which doesn't looks good.
<FormFieldv-slot="{ componentField }" name="name">
<FormItem
label="Name"
description="This is your public display name."
>
<FormControl>
<Input
type="text"
placeholder="How we can call you?"
v-bind="componentField"
autofocus
/>
</FormControl>
</FormItem>
</FormField>
I open this issue since was required in order to open PR which is here.
Additional information
I intend to submit a PR for this feature.
I have already implemented and/or tested this feature.
The text was updated successfully, but these errors were encountered:
Hello! Thank you for your contribution!
The philosophy of ShadCN is centered around providing unopinionated (or less opinionated) building blocks that empower developers to create their own custom (opinionated around their needs) components.
Any modification of the source code that would result in it being more opinionated (like the abstraction you coded) IMO is not aligned with this strategy.
This could be a valuable as an example though.
The unopinionated philosophy is understandable but compromises always has to happen. This is literally why I'm probably not going to use this framework. Is too complicated to make a simple form. See for example Quasar, it only requires a :rules="XYZ" function in each field and that's it.
Describe the feature
Right now we have many components for input, example:
We can reduce by passing, optionally, the label and description via props, and also the error is display conditionally instead of description, such avoiding to have description and error which doesn't looks good.
I open this issue since was required in order to open PR which is here.
Additional information
The text was updated successfully, but these errors were encountered: