Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): add svg classnames to new york style #877

Merged
merged 4 commits into from
Nov 10, 2024

Conversation

brianle1301
Copy link
Contributor

πŸ”— Linked issue

Closes #871

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adds svg classnames to the New York style button. The Default style already had these classnames. This ensures icons are of the correct size when placed inside buttons.

πŸ“Έ Screenshots (if appropriate)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@sadeghbarati
Copy link
Collaborator

Could you please do it for the default style

Also, run build:registry in apps/www directory

@brianle1301
Copy link
Contributor Author

@sadeghbarati The default already has these classnames. And sure, I can do a build

@brianle1301
Copy link
Contributor Author

brianle1301 commented Nov 9, 2024

@sadeghbarati Running build:registry seems to remove all the final new lines of the json outputs. Is this expected?

(Only the color and index ones I might add)

@sadeghbarati
Copy link
Collaborator

I'll check. Thanks πŸ™Œ

@sadeghbarati
Copy link
Collaborator

@sadeghbarati sadeghbarati merged commit 384c87a into unovue:dev Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Button missing svg classnames
2 participants