Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ship cli with package #1057

Open
SauravMaheshkar opened this issue Sep 25, 2024 · 1 comment · May be fixed by #1086
Open

feat: ship cli with package #1057

SauravMaheshkar opened this issue Sep 25, 2024 · 1 comment · May be fixed by #1086
Labels
feature request Feature request pending on roadmap good first issue

Comments

@SauravMaheshkar
Copy link

We could easily ship the unsloth cli (unsloth-cli.py) with the python package thereby increasing its portability and adoption.

Proposed Changes

  • migrate unsloth-cli.py to unsloth/cli.py.
  • Add a [project.scripts] section to pyproject.toml with the correct path.

Happy to work on this issue 😃
@danielhanchen
Copy link
Contributor

Sorry on the delay!! @SauravMaheshkar That'll be very cool indeed! If you're interested in working on it - that would be awesome! Also #1035 Leo made a cli v2 which might be of interest to you as well!

@danielhanchen danielhanchen added feature request Feature request pending on roadmap good first issue labels Oct 1, 2024
@SauravMaheshkar SauravMaheshkar linked a pull request Oct 1, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Feature request pending on roadmap good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(build): move cli within package SauravMaheshkar/unsloth
2 participants
@danielhanchen @SauravMaheshkar