FastLanguageModel.from_pretrained fails validate_repo_id in huggingface_hub

[AndreBremer]

This bug popped up post October-2024 tag. A glob file pattern makes it into HF's repo ID validator which causes it to fail.

Example:

    model, tokenizer = FastLanguageModel.from_pretrained(
        model_name="unsloth/Llama-3.2-1B-Instruct-bnb-4bit"
        ...
    )

Result:

huggingface_hub.errors.HFValidationError: Repo id must use alphanumeric chars or '-', '_', '.', '--' and '..' are forbidden, '-' and '.' cannot start or end the name, max length is 96: 'unsloth/Llama-3.2-1B-Instruct-bnb-4bit\*.json'.

[danielhanchen]

@Erland366 maybe related to the recent HF upload change maybe?

[Erland366]

Hmmm I can't seem to replicate them. I'll investigate more but maybe you have any new things happening here?

[AndreBremer]

Found the issue. It's Windows-specific. HfFileSystem doesn't handle backwards slashes in the path correctly and therefore mistakes it for a Repo ID. This only occurs on Windows with os.path.join.

Changing loader.py:213 from:

files = HfFileSystem(token = token).glob(os.path.join(model_name, "*.json"))

to something like:

files = HfFileSystem(token = token).glob(f"{model_name}/*.json")

fixes the issue.

[RealOfficialTurf]

Has anyone gotten around fixing this already? Am running on Windows and this also happens to me. The fix given by the author has worked for me, but I'd like to see this fix being implemented in the repo.

[rajan-fredrick-04]

Found the issue. It's Windows-specific. HfFileSystem doesn't handle backwards slashes in the path correctly and therefore mistakes it for a Repo ID. This only occurs on Windows with os.path.join.

Changing loader.py:213 from:

files = HfFileSystem(token = token).glob(os.path.join(model_name, "*.json"))

to something like:

files = HfFileSystem(token = token).glob(f"{model_name}/*.json")

fixes the issue.

Can anyone tell me where to do this?

[rajan-fredrick-04]

Has anyone gotten around fixing this already? Am running on Windows and this also happens to me. The fix given by the author has worked for me, but I'd like to see this fix being implemented in the repo.

@RealOfficialTurf Can you tell me where to change the needed?

[Erland366]

It's here @rajan-fredrick-04

unsloth/unsloth/models/loader.py

Line 134 in c45a0c3

files = HfFileSystem(token = token).glob(os.path.join(model_name, "*.json"))

You can directly modify this until unsloth officially fix this .-.

[danielhanchen]

@Erland366 Oh yes someone else make an issue about this - could you open a PR for this - thanks a lot!

[Erland366]

#1307 FIx this in this PR

[SergioRubio01]

Same problem here. I have tried to do it but still am not able to fix it. Is it already fix by any chance?