Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why isn't the action published to Github market place? #22

Open
suryasr007 opened this issue Apr 7, 2020 · 5 comments
Open

Why isn't the action published to Github market place? #22

suryasr007 opened this issue Apr 7, 2020 · 5 comments
Labels
question Further information is requested

Comments

@suryasr007
Copy link
Contributor

No description provided.

@aaronklaassen
Copy link
Member

aaronklaassen commented Apr 7, 2020

Because this was initially just in the Actions beta and I'm not sure the marketplace was open yet when I created it? And then I never got around to it? ¯\_(ツ)_/¯

But you're right, of course. I'll publish it.

@aaronklaassen aaronklaassen added the question Further information is requested label Apr 7, 2020
@lmeyerov
Copy link

lmeyerov commented Jul 2, 2020

@aaronklaassen In particular, would appreciate a versioning label to avoid regression risks between upgrades :)

@svenluijten
Copy link

svenluijten commented Jul 26, 2020

Yeah the reason seems to be that there's just some "tags", and no actual GitHub "releases": https://github.com/unsplash/comment-on-pr/releases. Once there's (for example) a v1.2.0 release, we can use this Action with unsplash/comment-on-pr@v1 instead of having to specify the exact version (unsplash/comment-on-pr@v1).

This'll also make it available on the marketplace I believe.

@aaronklaassen I'd love to get this done; is there any way I can help? 😄

@airtonix
Copy link

re: versioning. you can just use the commit hashes (it's just a commitish reference)

@lmeyerov
Copy link

We prefer frozen published (non-repo) versions to decrease risks like someone maliciously taking it down, force-pushing something else at the version, etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants