Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

url should be a peer dependency #17

Open
samhh opened this issue Apr 20, 2022 · 2 comments
Open

url should be a peer dependency #17

samhh opened this issue Apr 20, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@samhh
Copy link
Member

samhh commented Apr 20, 2022

Or we can stop using it as per #15.

@samhh samhh added the bug Something isn't working label Apr 20, 2022
@OliverJAsh
Copy link
Member

Even for Node? For Node it's built-in.

@OliverJAsh
Copy link
Member

To answer my own question: it's needed when someone tries to use this library outside of Node i.e. in the browser.

In that case, I'm not sure whether we should list url as a dependency or expect consumers to provide it themselves.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants