Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications #267

Open
Rosentti opened this issue Jan 24, 2024 · 7 comments
Open

Notifications #267

Rosentti opened this issue Jan 24, 2024 · 7 comments

Comments

@Rosentti
Copy link

You should receive notification when messages are received. Currently, only a sound is played.
Also, the indicator for where the message came is a bit unclear right now.

@ouwou
Copy link
Member

ouwou commented Jan 25, 2024

Also, the indicator for where the message came is a bit unclear right now.

which indicator?

if you are on windows, the lack of actual notifications is due to some technical restrictions. specifically, GTK (the GIO component in particular) doesnt provide a notification backend for windows, nor can i use something like wintoast since the necessary headers arent available in mingw64. i was considering making a separate helper program that can do the heavy lifting for windows specifically but im not very enthused about that

@Rosentti
Copy link
Author

I'm using KDE Plasma (Wayland) on Arch.
These are the indicators (the bits on the side):
image

But the indicators aren't really a problem, I rarely use them on regular Discord either and just look at the notification contents

@ouwou
Copy link
Member

ouwou commented Jan 26, 2024

strange that notifications dont work for you. do other application notifications work? does running notify-send trigger a notification?

@Rosentti
Copy link
Author

Vencorddesktop, discordcanary and notify-test all work fine.

@ouwou
Copy link
Member

ouwou commented Jan 28, 2024

does this little example program send a notification?
g++ test.cpp $(pkg-config gtkmm-3.0 --cflags --libs)

#include <gtkmm.h>

int main() {
    auto app = Gtk::Application::create("com.example.test");
    Gtk::Window window;
    window.set_default_size(300, 300);
    auto n = Gio::Notification::create("Test");
    n->set_body("test");
    n->set_default_action("app.go-to-channel::1");
    Glib::signal_timeout().connect_once([&]() {
        app->send_notification("123", n);
    }, 100);
    app->run(window);
}

@Rosentti
Copy link
Author

image
Yes.

@ouwou
Copy link
Member

ouwou commented Jan 29, 2024

thats pretty bizarre. if you really are getting the notification sound from abaddon that means effectively the same code is being run. you could maybe edit com.example.test in the test program with com.github.uowuo.abaddon to see if maybe you accidentally disabled notifications? if the test application still works with that change and you double checked your settings, maybe try removing lines 28-30 here and 34-35 to see if somehow the icon is preventing the notification from showing up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants