Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that other required Git ignores present #320

Open
karlhorky opened this issue Oct 18, 2022 · 0 comments
Open

Test that other required Git ignores present #320

karlhorky opened this issue Oct 18, 2022 · 0 comments
Assignees

Comments

@karlhorky
Copy link
Member

karlhorky commented Oct 18, 2022

Test that other required Git ignore files / folders are:

  1. present in .gitignore
  2. not present in Git

Like the node_modules check we already have

Check the https://github.com/upleveled/next-js-example-fall-2022/ repo for more

eg. the playwright/reports directory, preventing this issue of a student's GitHub repo being reported as "mostly HTML":

I had that as well. I guess you have a file in your playwright/report folder that is not ignored. because that apparently is a huge file with only html.
so I deleted it, checked my .gitignore file if it really is ignored and ran playwright again to check if it still works. afterwards the bar changed to the mostly TS

image

@karlhorky karlhorky self-assigned this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant