-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preflight Docker fails on libpg-query
installation
#394
Comments
After adding Python to the Dockerfile with
|
After adding Python to the Docker image, the build failed due to a missing After running this command locally, the Docker image was built successfully and Preflight was executed:
|
A) Ok, so the build dependencies is partially solved (still needs caching of the built dependencies so that B) But also, what about the other previous repos? They weren't reporting problems with unused dependencies before. What is causing this report now? |
I was able to avoid the error for unused dependencies in Kathi's e-commerce store and portfolio when switching to
When I update to the latest version of ESLint, I get the unused dependency errors:
|
Cool, so it's something with the changes in the ESLint config, I guess? What is causing it? |
I've discovered that if I include a
then the project will make use of the On the other hand, if I remove one of these variables, such as Preflight with a
Preflight without a
|
@ProchaLu Since you mentioned offline you're considering splitting this issue into 2 parts, you can document this in this issue and then link to the new issue:
|
Closed in #454
Moved this to: |
When attempting to install
libpg-query
in the Preflight Docker container, the following error is encountered:When running
pnpm install
inside the Docker image, the installation oflibpg-query
is failing due to the dependency on Python. Specifically, it seems that thenode-gyp
package used bylibpg-query
is requiring Python.Locally, when installing ESLint, a script is being executed (
node_modules/.pnpm/[email protected]/node_modules/libpg-query: Running install script...
). Since we changed the install command for the Docker image frompnpm install --ignore-scripts
topnpm install
in this commit, the same script is being executed inside Docker as well.I also tried using the older Docker image by reverting the changes made in this commit, but the errors are the same.
I tested different portfolios from the Winter Cohort 2023 using
yarn
and found no issues with@ts-safeql/eslint-plugin
andlibpg-query
as unused dependencies. However, switching topnpm
and upgrading to the latest version of ESLint, I encountered the following Preflight message:I also tested Kathi's Next.js e-commerce store using both
yarn
andpnpm
. While there were no issues with the unused dependencies when usingyarn
, I encountered the same Preflight message after switching topnpm
and upgrading to the latest version of ESLint.The text was updated successfully, but these errors were encountered: