Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imagePullSecrets to more ServiceAccounts #64

Open
mgladdish opened this issue Apr 26, 2018 · 1 comment
Open

Add imagePullSecrets to more ServiceAccounts #64

mgladdish opened this issue Apr 26, 2018 · 1 comment

Comments

@mgladdish
Copy link

mgladdish commented Apr 26, 2018

After much head scratching I think I've worked out that registry-creds only adds imagePullSecrets to the default service account in each namespace.

We lock down our pods by specifying our own, more restrictive, service accounts, so we don't get the awsecr-cred automatically added and our pods fail to download their image.

Maybe it could be possible to add an annotation to a service account to get it included in registry-creds' sync?

In the meantime, I presume the best/only workaround is to explicitly add the imagePullSecrets entry to our own service account definition?

It would also be good to make this more explicit in the readme - I've just spent 2 days trying to work out why registry-creds didn't work for one of my pods when it worked for all my others.

@stevesloka
Copy link
Member

Yup you are correct, an annotation would be an easy path to make this better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants