Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ReplicationController with Deployment #77

Closed
wants to merge 1 commit into from
Closed

Replace ReplicationController with Deployment #77

wants to merge 1 commit into from

Conversation

reegnz
Copy link
Contributor

@reegnz reegnz commented Oct 10, 2019

As the official k8s docs state:

Note: A Deployment that configures a ReplicaSet is now the recommended way to set up replication.

https://kubernetes.io/docs/concepts/workloads/controllers/replicationcontroller/

Fixes #76

@reegnz
Replace ReplicationController with Deployment
48f8a11 
As the official k8s docs state:

> Note: A Deployment that configures a ReplicaSet is now the recommended way to set up replication.

https://kubernetes.io/docs/concepts/workloads/controllers/replicationcontroller/
@stevesloka
Copy link
Member

Thanks for the PR @reegnz! I took your commit and fixed up the merge conflicts in #84.

@stevesloka stevesloka closed this Jan 27, 2020
@reegnz
Copy link
Contributor Author

reegnz commented Jan 28, 2020

Cool, thanks!

@xlanor xlanor mentioned this pull request Jul 21, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Deployment instead of ReplicaController
2 participants
@reegnz @stevesloka