Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar overlapping on the container if too many models #19

Open
romainbutteaud opened this issue Sep 12, 2014 · 7 comments
Open

Navbar overlapping on the container if too many models #19

romainbutteaud opened this issue Sep 12, 2014 · 7 comments
Labels

Comments

@romainbutteaud
Copy link

If you have more than 10-15 models, there is too much text which makes the navbar overlapping on the container.

@joncalhoun
Copy link
Member

Thanks for the feedback. I have noticed this is much more common when using something like acts-as-taggable, so I have a few ideas for fixing this by grouping up models in a dropdown menu (eg - group all models with ActsAsTaggable:: into a dropdown) but I need to figure out a good UI that works for models that don't group so well. I'll let you know when I have a good solution implemented.

@joncalhoun joncalhoun added the bug label Sep 13, 2014
@joncalhoun joncalhoun modified the milestone: Version 1.0 Sep 13, 2014
@jasoncox
Copy link

Maybe we should be manually configuring the menu as well as the models/tables we want to expose so we don't show habtm join tables etc.

This would give us a lot more control, and we could manually group the menus - we could define it in the model itself like:

class User < ActiveRecord::Base
  upminable 'Users', group: 'Foo'
end

What are your thoughts? I'd be happy to help out.

@joncalhoun
Copy link
Member

Something like this would be good, but I want to make sure we keep setup simple as well for anyone who isn't customizing things.

I am thinking we could default to using all models (except perhaps ones use in through relationships) and then if upminable is used in any single model, the default list of models is thrown out and only upminable models are used.

Does that sound like a resonable default?

@jasoncox
Copy link

I agree, that sounds good. Let me see what I can get done, I'm not familiar with ActsAsTaggable so I'll check that out and see whats going on there.

@joncalhoun
Copy link
Member

What I would probably look for is classes with a name like ActsAsTaggable::User and use the text before the :: as the dropdown menu name and group that way (assuming they aren't grouped via upminable). This should be generic enough to work for any act_as gem or anything like it.

@jasoncox
Copy link

Got it, I will default group menu items by namespace.

@joncalhoun
Copy link
Member

Awesome thanks :)
On Sep 14, 2014 7:50 PM, "Jason Cox" [email protected] wrote:

Got it, I will default group menu items by namespace.


Reply to this email directly or view it on GitHub
#19 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants