Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple jobs with the same name are treated as one job. #60

Open
krukowskid opened this issue Jan 19, 2023 · 2 comments
Open

Multiple jobs with the same name are treated as one job. #60

krukowskid opened this issue Jan 19, 2023 · 2 comments

Comments

@krukowskid
Copy link

krukowskid commented Jan 19, 2023

Hi there,
I am using reusable workflows and most of the workflows trigger the same set of jobs like

  - build-and-test / build
  - build-and-test / terraform-plan (prd, xwrd)
  - build-and-test / terraform-plan (dev, xwrd)
  - check-prstats / stats

It turns out that merge-gatekeeper v1.2.0 treats jobs with a common name as one job, and if one workflow succeeds while others are still running, it returns success. If any workflow fail before the first success then it returns failure

image

@rytswd
Copy link
Contributor

rytswd commented Jan 23, 2023

Hi @krukowskid - thanks for raising the issue! ☺️

We haven't been using reusable workflows internally, but this is certainly something we need to fix. We will check more into this and get a patch release out as soon as we can 🙏

@mmellison
Copy link

mmellison commented Apr 28, 2023

We recently ran into this issue as well since we decided to use reusable workflows and composite actions.

But otherwise thank you for this awesome project. We recently migrated some Monorepos from GitLab and we were shocked to find out GitHub doesn't have this functionality built in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants