-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Merge Queues #71
Comments
Hi @Fitzbert-Fitz, thanks for raising this! I was aware of the merge queue support, but didn't think it would have any impact to Merge Gatekeeper 😅 We haven't made use of it at UPSIDER, and while we may not have an immediate need for it, we would certainly want to support it if feasible. Let us have a closer look from our side to see what would be needed to support it -- if you have any ideas or suggestions, we would love to hear as well 🥰 |
I managed to workaround it like this:
|
`github.ref` breaks PRs, but works for merge queues, make it conditional. See upsidr/merge-gatekeeper#71 --------- Co-authored-by: Marcin Michalski <[email protected]>
We are happily using Merge-Gatekeeper in our github projects.
We are also looking into Github Merge Queues, which are GA since July.
I played a little bit and triggered merge-gatekeeper for github.event_group and handing down the github ref. It kinda looked promising but It had some side affects. It stopped working for PRs. ;-).
But since you do not officially support merge queues I will not report a bug. Instead I would like to ask for that support? Or guidence how to configure merge-gatekeeper for merge queues if it support it by default?
The text was updated successfully, but these errors were encountered: