Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto build gallery on PR merge #30

Open
bburns632 opened this issue Aug 28, 2019 · 2 comments
Open

auto build gallery on PR merge #30

bburns632 opened this issue Aug 28, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@bburns632
Copy link
Collaborator

Recently, @jameslamb generously contributed #28 by following our readme page. However, that does not automatically rebuild the website to make his contribution visible. #29 was needed for that.

So far, that has been a purposeful decision (eyeball the website before pushing). At some point soon, we should be able to trust the process enough to automatically rebuild the html from the .rmd file upon merge, perhaps with the addition of a few key unit tests.
@bburns632 bburns632 added the enhancement New feature or request label Aug 28, 2019
@jameslamb
Copy link
Collaborator

ignore the comment I just made on #29 haha, thanks for opening this issue!

@jameslamb jameslamb mentioned this issue Aug 29, 2019
Merged
@bburns632
Copy link
Collaborator Author

.github/workflows/ does not yet do that automatically but it does make it button push automated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jameslamb @bburns632