Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test framework #6

Closed
jameslamb opened this issue Mar 4, 2019 · 3 comments
Closed

Unit test framework #6

jameslamb opened this issue Mar 4, 2019 · 3 comments
Labels
ci help wanted Extra attention is needed

Comments

@jameslamb
Copy link

This project currently has no unit tests. To close this issue, just PR in a basic framework for testing (i.e. the basic structure and some minimal tests).

@jameslamb jameslamb added help wanted Extra attention is needed ci labels Mar 4, 2019
@Haoen-Cui
Copy link
Collaborator

@jameslamb Thanks for pointing this out. I have quite minimal experience with python flask apps, not even mentioning testing framework for it.

  • Could you please point me to some relevant resources?
  • If you are kind enough to set it up, I would be glad to review your PR

@jameslamb
Copy link
Author

I can't contribute this at this time. A first pass would be to set up very basic Travis that just runs python setup.py install to at least get PR build failures if the package can't be installed. You could look at how I set it up for doppel-cli but that is probably overkill for what you want (https://github.com/jameslamb/doppel-cli). See the .travis.yml file there.

I can't think of a good example right now for a simple setup for a Python project with a web service. I would start with the "get it installing" test and go from there.

Consider the docker on Travis option as a way to build and run the service. You could also ask @austin3dickey to point you to some examples of a cool project called responses which I really like for mocking HTTP requests (https://github.com/getsentry/responses).

@jameslamb
Copy link
Author

It looks like this project is abandoned. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants