Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R tests using deprecated testthat functionality #222

Closed
jameslamb opened this issue Dec 28, 2021 · 1 comment
Closed

R tests using deprecated testthat functionality #222

jameslamb opened this issue Dec 28, 2021 · 1 comment

Comments

@jameslamb
Copy link
Collaborator

{testthat} 3.0.0 was released in October 2020, and some functionality {uptasticsearch} uses from it is now considered deprecated.

From the {testthat} vignettes on v3.x (link), the following are deprecated and may be removed in a future major release:

  • testthat::context()
  • testthat::with_mock()

Uses of these functions should be removed, to prevent the package being removed from CRAN in the future if / when {testthat} completely removes those functions.

@jameslamb jameslamb changed the title remove deprecated testthat functionality [r-pkg] tests using deprecated testthat functionality Dec 28, 2021
@jameslamb jameslamb added the R label Dec 28, 2021
@jameslamb jameslamb changed the title [r-pkg] tests using deprecated testthat functionality R tests using deprecated testthat functionality Dec 28, 2021
@jameslamb
Copy link
Collaborator Author

I didn't realize we already had this issue 🤦🏻

context() was removed in #232

with_mock() was removed in #237 (linking #223 )

This is now complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant