Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows support in Travis #97

Closed
jameslamb opened this issue Oct 19, 2018 · 2 comments
Closed

Windows support in Travis #97

jameslamb opened this issue Oct 19, 2018 · 2 comments
Labels
help wanted python R

Comments

@jameslamb
Copy link
Collaborator

Travis recently added Windows support. Since many R users are also Windows users and Windows compatibility is necessary for packages to make it to CRAN, it would be valuable to test on Windows at CI time.

For anyone addressing this issue...you do not need to replicate ALL of our current Linux builds with Windows. One R build and one Python build (both with ES 6.2.x) would be sufficient.
@jameslamb jameslamb mentioned this issue Oct 19, 2018
Open
@jameslamb
Copy link
Collaborator Author

To close this issue, I actually think it would be ok to just install the package, set whatever environment variable tells testthat that it's on CRAN, and then runs the tests. The integration tests would all be skipped (only unit tests would be run) but that would still be a big improvement over the current state.

In other words...you do not need to set up Elasticsearch on Windows to address this issue

@jameslamb
Copy link
Collaborator Author

closing this as a duplicate of #145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted python R
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jameslamb