Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Change clang-tidy rules #117

Open
cajun-rat opened this issue Aug 4, 2024 · 0 comments
Open

RFC: Change clang-tidy rules #117

cajun-rat opened this issue Aug 4, 2024 · 0 comments

Comments

@cajun-rat
Copy link
Collaborator

At the moment we have a CI rule that requires all commits to be free of clang-tidy warnings, subject to the rules in .clang-tidy. This has three problems:

  • Upgrades add new clang-tidy checks, and this rules makes upgrades harder. The outcome is to break the backwards compatibility guarantees that C++ provides.
  • There is growing list of suppressed checks that would be nice to enforce on new code, but where existing code breaks them enough to make turning them on difficult. The outcome is that useful checks are currently disabled.
  • Fixing the issues creates churn in otherwise stable code, which has the potential to introduce bugs.

I propose changing this to enforce a different rule: "The diff may not contain (new) clang-tidy matches". We should be able to enforce this using clang-tidy-diff.py, which is distributed in the Debian clang packages).

cajun-rat added a commit that referenced this issue Aug 4, 2024
Upgrading the target language version also results in more clang-tidy
warnings. Fix up many of these, and disable the rest.

I also created #117 to discuss a
more robust approach to putting clang-tidy in the build.
cajun-rat added a commit that referenced this issue Aug 4, 2024
Upgrading the target language version also results in more clang-tidy
warnings. Fix up many of these, and disable the rest.

I also created #117 to discuss a
more robust approach to putting clang-tidy in the build.
cajun-rat added a commit that referenced this issue Aug 4, 2024
Upgrading the target language version also results in more clang-tidy
warnings. Fix up many of these, and disable the rest.

I also created #117 to discuss a
more robust approach to putting clang-tidy in the build.
cajun-rat added a commit that referenced this issue Aug 4, 2024
Upgrading the target language version also results in more clang-tidy
warnings. Fix up many of these, and disable the rest.

I also created #117 to discuss a
more robust approach to putting clang-tidy in the build.
cajun-rat added a commit that referenced this issue Aug 5, 2024
Upgrading the target language version also results in more clang-tidy
warnings. Fix up many of these, and disable the rest.

I also created #117 to discuss a
more robust approach to putting clang-tidy in the build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant