-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Change clang-tidy rules #117
Comments
cajun-rat
added a commit
that referenced
this issue
Aug 4, 2024
Upgrading the target language version also results in more clang-tidy warnings. Fix up many of these, and disable the rest. I also created #117 to discuss a more robust approach to putting clang-tidy in the build.
cajun-rat
added a commit
that referenced
this issue
Aug 4, 2024
Upgrading the target language version also results in more clang-tidy warnings. Fix up many of these, and disable the rest. I also created #117 to discuss a more robust approach to putting clang-tidy in the build.
cajun-rat
added a commit
that referenced
this issue
Aug 4, 2024
Upgrading the target language version also results in more clang-tidy warnings. Fix up many of these, and disable the rest. I also created #117 to discuss a more robust approach to putting clang-tidy in the build.
cajun-rat
added a commit
that referenced
this issue
Aug 4, 2024
Upgrading the target language version also results in more clang-tidy warnings. Fix up many of these, and disable the rest. I also created #117 to discuss a more robust approach to putting clang-tidy in the build.
cajun-rat
added a commit
that referenced
this issue
Aug 5, 2024
Upgrading the target language version also results in more clang-tidy warnings. Fix up many of these, and disable the rest. I also created #117 to discuss a more robust approach to putting clang-tidy in the build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment we have a CI rule that requires all commits to be free of clang-tidy warnings, subject to the rules in .clang-tidy. This has three problems:
I propose changing this to enforce a different rule: "The diff may not contain (new) clang-tidy matches". We should be able to enforce this using clang-tidy-diff.py, which is distributed in the Debian clang packages).
The text was updated successfully, but these errors were encountered: