Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running gitops commands with sequential=True doesn't print as it goes. #21

Open
jarekwg opened this issue Apr 20, 2020 · 0 comments
Open

Comments

@jarekwg
Copy link
Member

jarekwg commented Apr 20, 2020

The line here:

print(asyncio.run(run_job(app, command, cleanup=cleanup, sequential=sequential)))

is running individual jobs with async wrapped back to sync, unnecessarily. The result is that output isn't printed to the console until the whole job completes, rather than as the job runs.
Immediate output is important, as it allows jobs to be cancelled early as well as providing a rough idea of timing bottlenecks across the command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant