Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 18 support #251

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

React 18 support #251

wants to merge 2 commits into from

Conversation

ikappaki
Copy link
Contributor

@ikappaki ikappaki commented Mar 11, 2024

Hi,

could you please consider patch to upgrade the dependencies to support React 18. It fixes #228.

The approach taken here is to change as little as possible to make the lib compatible with React 18.

I have manually tested to work via storybook, which has also been upgraded to the latest version.

react-dnd could not be seamlessly upgraded due to the deprecation of the DragSource, DropTarget API in 15.0 in favor of the new useDrag hooks.

The change in the package script command line invocation to use npx ... is to support invocation on MS-Windows.

I have not endeavored to changed the demo-site because it appears as if it requires the package to be published first before picked up by the demo project.

Thanks

@jarekwg
Copy link
Member

jarekwg commented Mar 11, 2024

Hey @ikappaki -- we're seeking new maintainers for this package. Would you be interested?

@ikappaki
Copy link
Contributor Author

Hey @ikappaki -- we're seeking new maintainers for this package. Would you be interested?

Hi @jarekwg, thank you for the offer but unfortunately my Javascript knowledge is very basic, given also the complexity of the ecosystem, whence the minimalistic update in this PR. I am consuming the package in ClojureScript.

@nearone
Copy link

nearone commented Mar 18, 2024

Do you have some updates on this?

@jarekwg
Copy link
Member

jarekwg commented Mar 18, 2024

Hey Peeps,
Apologies, but we're no longer actively maintaining this package. We're happy for someone who has time to wear maintainer hat to review&merge the open PRs, and republish.
PM me!

@trungleduc
Copy link

Hi @jarekwg, I'm interested in maintaining this package. Currently, I'm maintaining a few NPM packages in the Jupyter ecosystem (https://www.npmjs.com/~trungleduc). Where can I contact you for more discussion?

@jarekwg
Copy link
Member

jarekwg commented Mar 19, 2024

Awesome!
Email me at [email protected]

@ikappaki
Copy link
Contributor Author

ikappaki commented Apr 1, 2024

Small correction with latest commit, react 18.x should be included as a peerDependency instead of replacing the existing ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not resolve dependency: React 18
4 participants