[MOBILE-3924] Update Unity plugin #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ulrico972
force-pushed
the
MOBILE-3924
branch
2 times, most recently
from
00ec7da to
66eaec2
Compare
Ulrico972
force-pushed
the
MOBILE-3924
branch
from
5d25deb to
c66428b
Compare
Ulrico972
force-pushed
the
MOBILE-3924
branch
from
1997103 to
e43ad0d
Compare
…o switch platform
Ulrico972
requested review from
crow,
rlepinski,
khmMouna,
oristanovic and
Apekka
as code owners
jyaganeh
approved these changes
Feb 26, 2024
Apekka
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
I also pushed the ProjectSettings files so GameCI uses them for the build. The most important one is ProjectVersion.txt, the rest can be left out if we don't want to push them, in that case we'll need to gitignore the directory for GameCI.
Why are these changes necessary?
How did you verify these changes?
Generating a unity package, adding it to a sample app, build that sample app and check the basic things, logs, channel ID, push, etc.
iOS is OK on my side.
Xcode 15 support is fine.
Android is OK.
Verification Screenshots:
Anything else a reviewer should know?
I ended up building the unity package in local and putting it in github so the release workflow can release it.
I don't think GameCI has anything to build the unity package and I didn't manage to find the Unity's files needed from GameCI docker image in order to build the unity package from the CI.
So for now, I think the better we can do is to just build the unity package in local and push it with our changes when we prepare a release.
For Android, the dependency resolving sometimes fails for some weird Unity reason. By adding a custom main gradle template and a custom gradle properties the customers can make the unity-jar-resolver get the dependencies with gradle perfectly.
We'll wait for the next release to fix the GCP issue in the release workflow and the following point:
We need to reserve a seat for Github on our Unity licence. I think we should just create a email address for that purpose because for now I used my account to set a token in the github secrets.