Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Natalia Makishvili #74

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Natalia Makishvili #74

wants to merge 7 commits into from

Conversation

natamaki
Copy link

@natamaki natamaki commented Feb 7, 2016

No description provided.

@mokhov
Copy link

mokhov commented Feb 11, 2016

А где filterEqual?

@natamaki
Copy link
Author

добавила filterEqual

@mokhov
Copy link

mokhov commented Feb 11, 2016

select не должен выбирать по неизвестным значениям


for (var i = 1; i < arguments.length; i++) {
collection = arguments[i](collection);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Здесь можно использовать reduce

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Попробовала reduce, получилось более громоздко, чем в текущей реализации.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Покажи

@natamaki
Copy link
Author

правки внесены

module.exports.query = function (collection /* операторы через запятую */) {
module.exports.query = function () {
var args = [].slice.call(arguments);
var collection = args[0];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var collection = args.shift();

следующую строчку можно удалить

@natamaki
Copy link
Author

@mokhov 🆙 правки внесены

@mokhov mokhov self-assigned this Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants