add support for custom viewport rects in bevy integration #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -88,6 +87,10 @@ pub struct GizmoOptions { | |||
| /// using a single gizmo. If `false`, each target | |||
| /// has its own gizmo. | |||
| pub group_targets: bool, | |||
| /// Allows you to provide a custom viewport rect, which will be used to | |||
| /// scale the cursor position. By default, this is set to `None` which means | |||
| /// the full window size is used as the viewport. | |||
There was a problem hiding this comment.
Thanks, looks great! I might change the wording here a bit, since one might assume that simply by setting the custom viewport rect, they can render the gizmo to the specified rect (even though it does say "will be used to scale the cursor position"). Technically the full window size is still used as the viewport, but only the interaction is affected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #54.