From 2e7daaf26f07c78b8682849362710bddbe7a4958 Mon Sep 17 00:00:00 2001 From: Uri Shaked Date: Mon, 8 Jul 2013 12:18:12 +0300 Subject: [PATCH] Added jshint --- .jshintrc | 26 ++++++++++++++++++++++++++ Gruntfile.js | 13 ++++++++++++- package.json | 3 ++- tests.js | 2 ++ 4 files changed, 42 insertions(+), 2 deletions(-) create mode 100644 .jshintrc diff --git a/.jshintrc b/.jshintrc new file mode 100644 index 0000000..d430ef2 --- /dev/null +++ b/.jshintrc @@ -0,0 +1,26 @@ +{ + "node": true, + "browser": true, + "esnext": true, + "bitwise": true, + "camelcase": true, + "curly": true, + "eqeqeq": true, + "immed": true, + "indent": 2, + "latedef": true, + "newcap": true, + "noarg": true, + "quotmark": "single", + "regexp": true, + "undef": true, + "unused": true, + "strict": true, + "trailing": true, + "smarttabs": true, + "maxdepth": 2, + "maxcomplexity": 10, + "globals": { + "angular": false + } +} diff --git a/Gruntfile.js b/Gruntfile.js index b7a8826..f1005e5 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -7,7 +7,6 @@ module.exports = function (grunt) { // load all grunt tasks require('matchdep').filterDev('grunt-*').forEach(grunt.loadNpmTasks); - var path = require('path'); grunt.initConfig({ karma: { @@ -16,6 +15,16 @@ module.exports = function (grunt) { singleRun: true } }, + jshint: { + options: { + jshintrc: '.jshintrc' + }, + all: [ + 'Gruntfile.js', + 'angular-moment.js', + 'tests.js' + ] + }, ngmin: { dist: { files: [ @@ -36,11 +45,13 @@ module.exports = function (grunt) { }); grunt.registerTask('test', [ + 'jshint', 'karma' ]); grunt.registerTask('build', [ 'ngmin', + 'jshint', 'uglify' ]); diff --git a/package.json b/package.json index 9df1c4f..5c20bda 100644 --- a/package.json +++ b/package.json @@ -6,6 +6,7 @@ "matchdep": "~0.1.1", "grunt": "~0.4.1", "grunt-contrib-uglify": "~0.2.0", + "grunt-contrib-jshint": "~0.6.0", "grunt-karma": "~0.5.0", "grunt-ngmin": "~0.0.2", "karma": "~0.9.4", @@ -15,6 +16,6 @@ "node": ">=0.8.0" }, "scripts": { - "test": "./node_modules/.bin/karma start" + "test": "./node_modules/.bin/grunt test" } } diff --git a/tests.js b/tests.js index 119920e..06ba35b 100644 --- a/tests.js +++ b/tests.js @@ -2,6 +2,8 @@ * Copyright (C) 2013, Uri Shaked. */ +/* global describe, inject, module, beforeEach, it, expect, waitsFor, runs */ + 'use strict'; describe('Directive: am-time-ago', function () {