Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback for “Tour options” #2078

Open
squigglybob opened this issue Sep 20, 2024 · 1 comment
Open

Feedback for “Tour options” #2078

squigglybob opened this issue Sep 20, 2024 · 1 comment
Labels

Comments

@squigglybob
Copy link

Description

Unclear/incorrect doc

buttonClass says

Additional classes to put on the buttons
Default: ""

But it seems to be replacing thi introjs-button class as well as adding in classes

Expected Behavior

The docs say, that buttonClass adds additional classes, but doesn't mention that it removes the introjs-button class.

Is it a bug that it is removing it? Or are the docs incorrect?

Locally, I'm just adding introjs-button into buttonClass to deal with this.
{ buttonClass: 'introjs-button an-additional-class' }

but thought it would be worth mentioning it.

It could be related to this issue #1700

Actual Behavior

But putting
{ buttonClass: 'an-additional-class' }
seems to be replacing the base button class

<a role="button" tabindex="0" class="an-additional-class introjs-nextbutton">Next</a>
compared to without buttonClass set

<a role="button" tabindex="0" class="introjs-button introjs-nextbutton">Next</a>

Example (recommended)

use {buttonClass: 'an-other-class'} in introjs options object

Environment (optional)

Brave browser Version 1.69.168 Chromium: 128.0.6613.138 (Official Build) (64-bit)
Using lit-html

Thanks

Thanks for running this codebase and the amazing product that it is.
Happy to run a PR once I know whether the code or the docs are correct

Copy link

stale bot commented Feb 1, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant