You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Description
Unclear/incorrect doc
buttonClass says
Additional classes to put on the buttons
Default: ""
But it seems to be replacing thi
introjs-button
class as well as adding in classesExpected Behavior
The docs say, that
buttonClass
adds additional classes, but doesn't mention that it removes the introjs-button class.Is it a bug that it is removing it? Or are the docs incorrect?
Locally, I'm just adding introjs-button into buttonClass to deal with this.
{ buttonClass: 'introjs-button an-additional-class' }
but thought it would be worth mentioning it.
It could be related to this issue #1700
Actual Behavior
But putting
{ buttonClass: 'an-additional-class' }
seems to be replacing the base button class
<a role="button" tabindex="0" class="an-additional-class introjs-nextbutton">Next</a>
compared to without buttonClass set
<a role="button" tabindex="0" class="introjs-button introjs-nextbutton">Next</a>
Example (recommended)
use
{buttonClass: 'an-other-class'}
in introjs options objectEnvironment (optional)
Brave browser Version 1.69.168 Chromium: 128.0.6613.138 (Official Build) (64-bit)
Using lit-html
Thanks
Thanks for running this codebase and the amazing product that it is.
Happy to run a PR once I know whether the code or the docs are correct
The text was updated successfully, but these errors were encountered: